feat: Added Live-Streaming Functionality #64
Conversation
There was a problem hiding this comment.
Hi @Jish261203 Thanks for raising PR. But as it contains multiple file change, so needs more attention to review this PR. Reviewed some part. I think due to indentation problem at your end, some lines of code came under red colored patch unnecessarily. Can you rectify at your end once and recheck....It will be easier for PA/mentor to go through the review work.
| var chars = | ||
| "12345qwertyuiopasdfgh67890jklmnbvcxzMNBVCZXASDQWERTYHGFUIOLKJP", |
There was a problem hiding this comment.
Hi @Jish261203 What is this string here under chars. If it has to be protected then you should keep it in env file?? Explain a bit more about this 2 line.
There was a problem hiding this comment.
Hi @ashutoshgithubs the string "12345qwertyuiopasdfgh67890jklmnbvcxzMNBVCZXASDQWERTYHGFUIOLKJP" contains a mix of digits (0-9), lowercase letters (a-z), and uppercase letters (A-Z).This string act as pool of characters from ehich function will randomly selects to create a unique Id
|
Hi @Jish261203 Your PR causing conflict !! |
|
Thank you for submitting this pull request. |
What does the PR do?
Add the Live Streaming is added to Instructor using ZEGOCLOUD service
Features #56
Type of change ☑️
What sort of change have you made:
1.Made account on ZEGOCLOUD service .
2.selected the specific intergration that is live-streaming.
3.Created two file Room.jsx and Stream.jsx under pages folder
Screenshot of the changes made in my work:
meet2.mp4