Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new endpoint to get filtered courses according to price and category id #74

Open
wants to merge 1 commit into
base: DevG_Contribute
Choose a base branch
from

Conversation

sumitt-kun
Copy link

@sumitt-kun sumitt-kun commented May 14, 2024

Issue Title: New Feature: New endpoint to get filtered courses according to price and category id.

resolve issue: #46

I have added a new endpoint to get filtered courses according to price and category id. Please note that if you don't add price in body while making http request then it will return all free courses(i.e price=0). Also if you don't add category id then it will return courses with any category.(i.e no filter on courses will be applied)

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshot of the changes made in your work (if applicable):

Screenshot (3575)
Screenshot (3576)

How Has This Been Tested? ⚙️

I've tested it on postman.
Screenshot (3570)
Screenshot (3574)

Screenshot (3573)

Screenshot (3572)

Screenshot (3571)

Copy link

Thank you for submitting this pull request.
We will review the changes and get in contact with you as soon as possible.

Copy link
Owner

@ashutoshgithubs ashutoshgithubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sumitt-kun Thanks for your Backend logic. It seems fine. It would be great if you integrate some of your frontend work. Good luck! :)

@sumitt-kun
Copy link
Author

sumitt-kun commented May 19, 2024

hey @ashutoshgithubs , is it okay if I add the frontend part as a new issue since this is marked just a level 2? Other people are literally just changing little bit of styling/adding just 2-3 lines of code and getting 10 points(for a level 1 issue) :(
Please let me know, if its fine. Otherwise I'll add the frontend part in this one only.

@sumitt-kun
Copy link
Author

@ashutoshgithubs ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants