Add support for adding tags to tasks and limiting lists#61
Open
hardaker wants to merge 2 commits intoasmfreak:masterfrom
Open
Add support for adding tags to tasks and limiting lists#61hardaker wants to merge 2 commits intoasmfreak:masterfrom
hardaker wants to merge 2 commits intoasmfreak:masterfrom
Conversation
Contributor
Author
|
This also solves issue #15 |
asmfreak
reviewed
Feb 19, 2025
| class Habits(TasksPrint): # pylint: disable=missing-docstring | ||
| DESCRIPTION = _("List, up and down habit tasks") # noqa: Q000 | ||
| domain = 'habits' | ||
| tag = cli.SwitchAttr( |
Owner
There was a problem hiding this comment.
Can you please try to move this to its base class (TagsHelper)?
Owner
There was a problem hiding this comment.
Also, please use a repeatable switch. See plumbum docs on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note, this add support for adding tags to tasks when creating them:
habitipy todos add -t myshineytag my new todo entryAnd for limiting lists as well:
habitipy todos -t myshineytagNote to consider: There are three instances where the API returns a dict, by mypy expects a list so I'm using cast() to properly cast them to dicts (which they already are). The right thing to do would be fix the post API return specification, but I wasn't sure how to do that. What I did works, but if someone wants to tackle fixing the API itself that would be better.