Skip to content

Conversation

@jbedard
Copy link
Member

@jbedard jbedard commented Oct 3, 2025

Changes are visible to end-users: no

Test plan

  • New test cases added

@jbedard jbedard requested a review from alexeagle October 3, 2025 21:00
@aspect-workflows
Copy link

aspect-workflows bot commented Oct 3, 2025

Test

30 test targets passed

Targets
//js/private/test/node-patches:escape_node16_test [k8-fastbuild]   293ms
//js/private/test/node-patches:escape_node18_test [k8-fastbuild]   270ms
//js/private/test/node-patches:escape_node20_test [k8-fastbuild]   156ms
//js/private/test/node-patches:escape_node22_test [k8-fastbuild]   190ms
//js/private/test/node-patches:escape_node24_test [k8-fastbuild]   327ms
//js/private/test/node-patches:lstat_node16_test [k8-fastbuild]    293ms
//js/private/test/node-patches:lstat_node18_test [k8-fastbuild]    366ms
//js/private/test/node-patches:lstat_node20_test [k8-fastbuild]    201ms
//js/private/test/node-patches:lstat_node22_test [k8-fastbuild]    251ms
//js/private/test/node-patches:lstat_node24_test [k8-fastbuild]    342ms
//js/private/test/node-patches:opendir_node16_test [k8-fastbuild]  345ms
//js/private/test/node-patches:opendir_node18_test [k8-fastbuild]  384ms
//js/private/test/node-patches:opendir_node20_test [k8-fastbuild]  233ms
//js/private/test/node-patches:opendir_node22_test [k8-fastbuild]  185ms
//js/private/test/node-patches:opendir_node24_test [k8-fastbuild]  425ms
//js/private/test/node-patches:readdir_node16_test [k8-fastbuild]  229ms
//js/private/test/node-patches:readdir_node18_test [k8-fastbuild]  474ms
//js/private/test/node-patches:readdir_node20_test [k8-fastbuild]  323ms
//js/private/test/node-patches:readdir_node22_test [k8-fastbuild]  385ms
//js/private/test/node-patches:readdir_node24_test [k8-fastbuild]  293ms
//js/private/test/node-patches:readlink_node16_test [k8-fastbuild] 264ms
//js/private/test/node-patches:readlink_node18_test [k8-fastbuild] 266ms
//js/private/test/node-patches:readlink_node20_test [k8-fastbuild] 455ms
//js/private/test/node-patches:readlink_node22_test [k8-fastbuild] 261ms
//js/private/test/node-patches:readlink_node24_test [k8-fastbuild] 308ms
//js/private/test/node-patches:realpath_node16_test [k8-fastbuild] 316ms
//js/private/test/node-patches:realpath_node18_test [k8-fastbuild] 307ms
//js/private/test/node-patches:realpath_node20_test [k8-fastbuild] 295ms
//js/private/test/node-patches:realpath_node22_test [k8-fastbuild] 254ms
//js/private/test/node-patches:realpath_node24_test [k8-fastbuild] 332ms

Total test execution time was 9s. 220 tests (88.0%) were fully cached saving 32s.


Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 621ms.


Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 200ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 5s.


Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 605ms.


Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 479ms.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 164ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 61ms.


Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 387ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 114ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 496ms.


Test

e2e/pnpm_lockfiles

All tests were cache hits

67 tests (100.0%) were fully cached saving 10s.


Test

e2e/pnpm_workspace

All tests were cache hits

15 tests (100.0%) were fully cached saving 2s.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

15 tests (100.0%) were fully cached saving 4s.


Test

e2e/repo_mapping

All tests were cache hits

3 tests (100.0%) were fully cached saving 466ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 246ms.


Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 111ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 118ms.


Buildifier      Format

@jbedard jbedard force-pushed the esm-escaping-even-older-node branch from 4d5e103 to 0ff53eb Compare October 3, 2025 21:45
@dzbarsky
Copy link
Collaborator

dzbarsky commented Oct 6, 2025

@codex please review this

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

@jbedard jbedard merged commit d823419 into aspect-build:main Oct 6, 2025
98 of 99 checks passed
@jbedard jbedard deleted the esm-escaping-even-older-node branch October 6, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants