Fix exec_properties for py_test #529
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
keith
commented
Feb 13, 2025
| @@ -60,13 +60,17 @@ py_image_layer = _py_image_layer | |||
| resolutions = _resolutions | |||
|
|
|||
| def _py_binary_or_test(name, rule, srcs, main, deps = [], resolutions = {}, **kwargs): | |||
| exec_properties = kwargs.pop("exec_properties", {}) | |||
| non_test_exec_properties = {k: v for k, v in exec_properties.items() if not k.startswith("test.")} | |||
There was a problem hiding this comment.
clearly not ideal, im not sure forwarding everything is really the right move below, technically the new exec_group_compatible_with attr also would have this issue.
keith
force-pushed
the
ks/fix-exec_properties-for-py_test
branch
from
a84071f to
ade07c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #461