Skip to content

Conversation

@jbedard
Copy link
Member

@jbedard jbedard commented Dec 4, 2024

I found this confusing, and now this avoids invoking _is_typings_src 2x for every single src within the ts_config rule.


Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@jbedard jbedard requested a review from dzbarsky December 4, 2024 01:50
@jbedard jbedard enabled auto-merge (squash) December 4, 2024 01:50
@aspect-workflows
Copy link

aspect-workflows bot commented Dec 4, 2024

Test

All tests were cache hits

154 tests (100.0%) were fully cached saving 9s.


Buildifier      Format

@jbedard jbedard merged commit 18d5010 into aspect-build:main Dec 4, 2024
24 checks passed
@jbedard jbedard deleted the simplify-double-neg branch December 4, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants