Skip to content

Conversation

@jbedard
Copy link
Member

@jbedard jbedard commented Sep 25, 2025

Adding tests to ensure there's no odd bugs/dx issues.

Close #828

Changes are visible to end-users: no

Test plan

  • New test cases added

@jbedard jbedard requested review from arrdem and thesayyn September 25, 2025 18:32
@aspect-workflows
Copy link

aspect-workflows bot commented Sep 25, 2025

Test (Bazel 6.x) (Test)

All tests were cache hits

180 tests (100.0%) were fully cached saving 13s.


Test (Bazel 7.x) (Test)

1 test target passed

Targets
//examples/out_dir:test [k8-fastbuild] 60ms

Total test execution time was 60ms. 179 tests (99.4%) were fully cached saving 13s.


Test (Bazel 8.x) (Test)

All tests were cache hits

180 tests (100.0%) were fully cached saving 13s.


Bazel-7

e2e/bzlmodules

All tests were cache hits

1 test (100.0%) was fully cached saving 32ms.


Bazel-8

e2e/bzlmodules

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.


Bazel-6

e2e/external_dep

All tests were cache hits

6 tests (100.0%) were fully cached saving 332ms.


Bazel-7

e2e/external_dep

All tests were cache hits

6 tests (100.0%) were fully cached saving 289ms.


Bazel-8

e2e/external_dep

All tests were cache hits

6 tests (100.0%) were fully cached saving 291ms.


Bazel-7

e2e/smoke

All tests were cache hits

2 tests (100.0%) were fully cached saving 107ms.


Bazel-8

e2e/smoke

All tests were cache hits

2 tests (100.0%) were fully cached saving 149ms.


Bazel-6

e2e/test

4 test targets passed

Targets
//examples/root_dir:dot-slash_test [k8-fastbuild]91ms
//examples/root_dir:dot-slash_typecheck_test [k8-fastbuild]93ms
//examples/root_dir:dot_test [k8-fastbuild]42ms
//examples/root_dir:dot_typecheck_test [k8-fastbuild]47ms

Total test execution time was 273ms. 176 tests (97.8%) were fully cached saving 13s.


Bazel-7

e2e/test

All tests were cache hits

180 tests (100.0%) were fully cached saving 13s.


Bazel-8

e2e/test

All tests were cache hits

180 tests (100.0%) were fully cached saving 13s.


Bazel-6

e2e/worker

All tests were cache hits

6 tests (100.0%) were fully cached saving 368ms.


Bazel-7

e2e/worker

All tests were cache hits

6 tests (100.0%) were fully cached saving 287ms.


Bazel-8

e2e/worker

All tests were cache hits

6 tests (100.0%) were fully cached saving 363ms.


Buildifier      Format

@jbedard jbedard merged commit 8c63389 into aspect-build:main Oct 2, 2025
19 checks passed
@jbedard jbedard deleted the 828-outdir branch October 2, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Error: When outDir is set in the tsconfig it must also be set in the ts_project rule, so that the output directory is known to Bazel

2 participants