-
-
Notifications
You must be signed in to change notification settings - Fork 15
Update the interface and ginga implementation to make some changes of the marker API #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7e71dc9
Make default marker names explicit
mwcraig 12b7aa1
Add ability to pass list of marker names to get_markers
mwcraig 11ee100
Add "all" option to remove_markers
mwcraig 09b622e
Allow remove_markers to accept list of names
mwcraig 95a96ed
PEP8 fixes
mwcraig ef4035f
Use array comparison in test
mwcraig 851c88e
Remove unnecessary use of np.random in response to review
mwcraig 2db7faf
Return an empty table if markers not found
mwcraig b391c98
Remove redundant test
mwcraig 00c6470
Revise tests to look for new behavior when marker is not found
mwcraig 2231d05
Update ginga backend to follow new get_markers API
mwcraig 021fcb6
Remove unused import
mwcraig 98f2680
Apply suggestions from code review
mwcraig b50ee9c
Remove unnecessary uses of random numbers
mwcraig a240d9f
Fix broken test
mwcraig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, won't setting pytest to turn all warnings into exceptions take care of this?