Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

created package for websockets server in an executable binary #63

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

created package for websockets server in an executable binary #63

wants to merge 3 commits into from

Conversation

sachin2912
Copy link

resolves #57 @t0xic0der

@amaank404
Copy link
Contributor

i had a question to your work, What platforms does your pull request add?

@amaank404
Copy link
Contributor

i also recommend you to remove the build folder (It is unnecessary).

@amaank404
Copy link
Contributor

keep it up 👍

@sachin2912
Copy link
Author

executable binary file created is for Linux (as sanctuary is not tested on windows yet) , specifically Ubuntu 20.04 LTS and python 3.8.2 . build folder can be useful for debugging , still if maintainer want i can remove build folder.

@gridhead gridhead self-requested a review October 5, 2020 02:47
@gridhead
Copy link
Member

gridhead commented Oct 5, 2020

i had a question to your work, What platforms does your pull request add?

Sanctuary works only in GNU/Linux based operating systems. I thought that was evident with the screenshots attached in the documentation.

i also recommend you to remove the build folder (It is unnecessary).

I believe we should leave that for the maintainer to decide about the stuff which is necessary and about those which aren't.

@gridhead
Copy link
Member

gridhead commented Oct 5, 2020

@sachin2912 Thanks for your contribution to the repository. Allow us some time to review your pull request.

gridhead
gridhead requested changes Oct 5, 2020
View reviewed changes
Copy link
Member

@gridhead gridhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch with adding the documentation pertaining to the executable binary. Also, could you please explain the significance of the newly-created xref-chatroom.html?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gridhead gridhead gridhead requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package the websockets server in an executable binary
3 participants
@sachin2912 @amaank404 @gridhead