Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for cpp constraint #1687

Merged
merged 8 commits into from
Dec 26, 2023
Merged

test: add test for cpp constraint #1687

merged 8 commits into from
Dec 26, 2023

Conversation

Gmin2
Copy link
Contributor

@Gmin2 Gmin2 commented Dec 25, 2023

Description

Added test for cpp constraint

Related Issue

Fixes #1670

Checklist

  • [✅ ] The code follows the project's coding standards and is properly linted (npm run lint)
  • [✅ ] Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • [ ✅] All tests pass successfully locally.(npm run test).

Additional Notes

This is work in progress

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Dec 25, 2023

Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit 31bd783
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/658a68cbe8746d00088902e3

@Gmin2 Gmin2 changed the title added test for cpp constraint fix: added test for cpp constraint Dec 25, 2023
@Gmin2 Gmin2 marked this pull request as ready for review December 25, 2023 13:06
@jonaslagoni jonaslagoni changed the title fix: added test for cpp constraint test: add test for cpp constraint Dec 25, 2023
@coveralls
Copy link

coveralls commented Dec 25, 2023

Pull Request Test Coverage Report for Build 7326993527

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 92.296%

Totals Coverage Status
Change from base Build 7308571585: 0.03%
Covered Lines: 5864
Relevant Lines: 6192

💛 - Coveralls

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just got one comment 🙂

@Gmin2 Gmin2 requested a review from jonaslagoni December 25, 2023 17:49
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a few linting problems 🙂

@Gmin2 Gmin2 requested a review from jonaslagoni December 26, 2023 05:44
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

25.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @Min2who 🙇

@jonaslagoni jonaslagoni merged commit e18b4a7 into asyncapi:master Dec 26, 2023
13 of 14 checks passed
@jonaslagoni
Copy link
Member

@all-contributors please add @Min2who for test

Copy link
Contributor

@jonaslagoni

I've put up a pull request to add @Min2who! 🎉

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add C++ constraint tests
4 participants