dkms: Detect errors on install/uninstall #278
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakra
force-pushed
the
queue/detect-dkms-install-errors
branch
2 times, most recently
from
c282b6e to
3b8a220
Compare
kakra
force-pushed
the
queue/detect-dkms-install-errors
branch
from
3b8a220 to
46acf45
Compare
kakra
force-pushed
the
queue/detect-dkms-install-errors
branch
from
46acf45 to
7231f59
Compare
24 tasks
kakra
force-pushed
the
queue/detect-dkms-install-errors
branch
3 times, most recently
from
f8159e4 to
81c6866
Compare
Signed-off-by: Kai Krakow <[email protected]>
kakra
force-pushed
the
queue/detect-dkms-install-errors
branch
from
81c6866 to
0e3cae9
Compare
|
Code Climate has analyzed commit 0e3cae9 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Pull Request Overview
Enhances error detection in DKMS install/uninstall scripts by adding the -e flag to shell shebangs, which causes scripts to exit immediately if any command fails.
- Added
-eflag to shell shebangs in both DKMS post-install and post-remove scripts
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| hid-xpadneo/dkms.post_install | Added -e flag to shebang for immediate error exit |
| hid-xpadneo/dkms.post_remove | Added -e flag to shebang for immediate error exit |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's try if we can catch problems during automatic testing.
Todo: