v0.10: CI testing of patch queue #463
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakra
force-pushed
the
queue/for-0.10
branch
6 times, most recently
from
a8666ca to
12f4608
Compare
kakra
force-pushed
the
queue/for-0.10
branch
4 times, most recently
from
afd33fa to
f61508f
Compare
kakra
force-pushed
the
queue/for-0.10
branch
from
e641e48 to
5f89259
Compare
kakra
force-pushed
the
queue/for-0.10
branch
9 times, most recently
from
dfc5015 to
e87d88b
Compare
kakra
force-pushed
the
queue/for-0.10
branch
5 times, most recently
from
bc8b92f to
72e6825
Compare
kakra
force-pushed
the
queue/for-0.10
branch
2 times, most recently
from
8dee9da to
a402d70
Compare
`dkms remove` may fail because a previous installation has been broken or tampered with. This will cause the remaining uninstallation to fail. Fix this by logging that we proceed anyways. Suggested-by: flodavid <[email protected]> Link: atar-axis#563 Signed-off-by: Kai Krakow <[email protected]>
This change is backwards compatible with older versions. Link: https://github.com/systemd/systemd/blob/781d9d0789379d1ea1f2ecefb804d41e9c8b6c38/NEWS#L22-L32 Closes: atar-axis#559 Signed-off-by: Kai Krakow <[email protected]>
Signed-off-by: Kai Krakow <[email protected]>
The system should trigger loading of the `uhid` module when `bluetooth` is loaded to properly support BLE devices which provide the HID bus from user-space through bluez. This may still leave a gap for a race-condition if both `bluetooth` and the BLE device appear at the same time. `uhid` should be present before any device even connects from user-space, otherwise `hid-xpadneo` may not see the HID bus early enough. I'm unsure if we also should provide `weakdep` to trigger inclusion of `uhid` into initrd - but since Xbox controllers are not critical input devices during early boot, this is probably not our business. OTOH, `softdep` may already trigger inclusion on its own (untested). Hint: This feels wrong because xpadneo is the HID consumer, not the HID provider. We should not need to do that. But it prevents bug reports from users in the future. Tested-by: flodavid <[email protected]> Link: atar-axis#563 (comment) Signed-off-by: Kai Krakow <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the xpadneo driver to require kernel 5.12 or higher, removing legacy ERTM (Enhanced Retransmission Mode) workarounds that are no longer needed. It also adds profile switching support and fixes udev rule patterns.
- Removes ERTM override logic and installation scripts
- Adds profile button reporting functionality
- Updates minimum kernel version from 4.18.0 to 5.12.0
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| install.sh | Adds warning for unsupported kernel versions below 5.12 |
| hid-xpadneo/src/xpadneo.h | Adds profile button macro and last_profile tracking field |
| hid-xpadneo/src/hid-xpadneo.c | Implements profile button registration and reporting |
| hid-xpadneo/etc-udev-rules.d/70-xpadneo-disable-hidraw.rules | Simplifies ACTION pattern to use negation |
| hid-xpadneo/etc-udev-rules.d/60-xpadneo.rules | Simplifies ACTION pattern to use negation |
| hid-xpadneo/etc-modprobe.d/xpadneo.conf | Adds uhid softdep for bluetooth module |
| hid-xpadneo/dkms.post_remove | Removes ERTM logic, updates comment |
| hid-xpadneo/dkms.post_install | Removes ERTM override installation logic |
| hid-xpadneo/dkms.conf.in | Updates minimum kernel version to 5.12.0 |
| Makefile | Adds error suppression to dkms remove command |
| .github/workflows/checkpatch.yml | Adds new GitHub workflow for kernel coding style checks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kakra
force-pushed
the
queue/for-0.10
branch
2 times, most recently
from
3d915fa to
25618fe
Compare
AI checks identified the check being inverted. Fixes: 25d0ea1 ("xpadneo, installer: Get rid of ERTM work-around by requiring kernel 5.12") Signed-off-by: Kai Krakow <[email protected]>
Do not leak the error pointer into the battery struct if psy registration failed. Signed-off-by: Kai Krakow <[email protected]>
If `ida_simple_get()` fails, we didn't properly bubble up the error to the device manager. Signed-off-by: Kai Krakow <[email protected]>
battery.desc.name was never freed during device removal because this previously caused a kernel crash when xpadneo tried to free the name itself. Fix this by using the devm memory manager so we don't need to clean up memory by ourselves. Also fix input_dev->name which has been an oversight previously. Signed-off-by: Kai Krakow <[email protected]>
Signed-off-by: Kai Krakow <[email protected]>
This confuses code analysis. Signed-off-by: Kai Krakow <[email protected]>
Signed-off-by: Kai Krakow <[email protected]>
Signed-off-by: Kai Krakow <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Kai Krakow <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Kai Krakow <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only runs the CI tests on the patch queue. Commits are subject to change, do not base your own work on this.