Fix for mousewheel scrolling bug with regards to decimal increments #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes and issue where s.o.step was being treated as a string instead of a number
This fixes an issue where a decimal being incremented by .1 for example would manifest itself as 1.10000000005 and display as such in the text field of the knob - mostly and esthetic issue
Added on change notifications to mousewheel scrolling and arrow key interactions. Also minified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a pair of fixes for mousewheel scrolling when a knob is set to use decimal increments (it appears the issue doesnt exists if it is set to the default or whole number increments). The first commit fixes an issue where NaN was being generated. The second commit is more an esthetic fix so that numbers like 2.00000000001 are not generated when the desired output would be something like 2.0 or 2.1 for example.