Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding log level configuration from env variable #182

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

italovalcy
Copy link
Contributor

Fix #176

Description of the change

As discussed during the All Hands Meeting, it would be nice if we have means to change the log level of the SDX components for production environment. In production, having the log level hardcoded to DEBUG is not recommended. With this PR, the SDX-LC operator can now set an environment variable called LOG_LEVEL and change this behavior.

For backward compatibility, the LOG_LEVEL defaults to "DEBUG" just as current behavior.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13334264364

Details

  • 2 of 5 (40.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 80.936%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_lc/app.py 0 3 0.0%
Totals Coverage Status
Change from base Build 12917532142: -0.04%
Covered Lines: 1210
Relevant Lines: 1495

💛 - Coveralls

@italovalcy italovalcy self-assigned this Feb 14, 2025
Copy link
Collaborator

@YufengXin YufengXin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@congwang09 congwang09 merged commit c2e531c into main Feb 19, 2025
11 checks passed
@congwang09 congwang09 deleted the fix/issue_176 branch February 19, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log level should be configurable
4 participants