Support Enum into String for hydration#724
Open
AlexandreCarlton wants to merge 1 commit into
Open
Conversation
In GraphQL, `enum` types are serialised into `String` - as such, it is reasonable to expect that we can supply an `enum` type to a field expecting a `String` as input.
|
Thank you for your submission! Like many open source projects, we ask that you sign our CLA (Contributor License Agreement) before we can accept your contribution. Already signed the CLA? To re-check, try refreshing the page. |
Author
|
I can't seem to sign the CLA - I'm guessing because I must have already signed it to contribute to 
|
Collaborator
|
Looks good, I think an integration test would be good too. I'll add one and merge later today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In GraphQL,
enumtypes are serialised intoString- as such, it is reasonable to expect that we can supply anenumtype to a field expecting aStringas input.See also #723 which lays the groundwork for conditional hydration (which would be built off in a subsequent PR).