-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Eslint 9 #87
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the configuration files to support ESLint 9 by refining type imports and restructuring configuration objects into arrays when needed. Key changes include replacing regular imports with type-only imports for ESLint’s Linter, updating configuration types from ConfigOverride to Config, and refactoring setup for various language-specific ESLint plugins.
Reviewed Changes
Copilot reviewed 23 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/plugin-node-rules.cts | Changed import to type-only for ESLint’s Linter |
src/plugin-import-rules.cts | Changed import to type-only for ESLint’s Linter |
src/official-eslint-rules.cts | Changed import to type-only for ESLint’s Linter |
src/json.cts | Updated configuration type and plugin usage |
src/javascript.cts | Updated jsConfig type to an array and refined parser options |
src/index.cts | Updated config structure to an array and import changes |
src/index-strict*.cts | Commented out removal of only-warn for non-strict configurations |
src/index-solid.cts | Refactored solid config integration |
src/index-react.cts | Refactored react config integration |
src/html.cts | Updated html config to use object style plugins |
src/cson.cts | Updated cson config to new configuration type |
src/coffeescript.cts | Updated coffeescript config to new configuration type |
src/astro.cts | Updated astro config to array-based configuration |
prettier.config.mjs | Added prettier configuration import |
eslint.config.cjs | Updated export to spread the array configuration |
Files not reviewed (2)
- .eslintrc.json: Language not supported
- package.json: Language not supported
Comments suppressed due to low confidence (1)
src/index.cts:7
- The variable name 'pluginOptmizeRegex' appears to contain a typo; consider renaming it to 'pluginOptimizeRegex' for clarity.
import pluginOptmizeRegex from "eslint-plugin-optimize-regex"
No description provided.