Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

GitHub Actions #238

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

GitHub Actions #238

wants to merge 1 commit into from

Conversation

aminya
Copy link

@aminya aminya commented Nov 12, 2020

Description of the change

Use GitHub Actions instead of Travis and Appveyor.

Benefits

  • GitHub Actions is much faster than the other CI services and allows parallel runs
  • GitHub Actions it is much easier to configure.
  • Atom is a GitHub product, so we should use GitHub Actions.
  • Travis is making its services limited and monetary.
    https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing

Verification

The CI passes: https://github.com/aminya/language-java/actions/runs/359820773

Drawbacks

none

Release Notes

N/A

@sadikovi
Copy link
Contributor

Hello. Thanks for opening a pull request. I would like to understand the changes. Why is it necessary to update the CI?

The current CI:

  • Is pretty fast anyway. Multiple PRs can also run parallel builds.
  • We do not configure CI very often.
  • Travis continues to remain free for open-source projects, albeit with new limitations.

Would like to know if there is an existing precedent, e.g. other atom language repos have migrated to github actions.

@aminya
Copy link
Author

aminya commented Nov 21, 2020

Hello. Thanks for opening a pull request. I would like to understand the changes. Why is it necessary to update the CI?

Hi. I mentioned the reasons for this change in the above post:

  • GitHub Actions is much faster than the other CI services and allows parallel runs
  • GitHub Actions is much easier to configure.
  • Atom is a GitHub product, so we should use GitHub Actions.
  • Travis is making its services limited and monetary: https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing

Extra points:

  • The Travis/Appveyor script does not show what exactly is running (running some bash script from somewhere else). Using GitHub Actions this becomes very obvious
  • GitHub Actions is a unified place. No need for two different files for different operating systems.

The current CI:

  • Is pretty fast anyway. Multiple PRs can also run parallel builds.
  • AppVeyor does not allow parallel builds, and it is painfully slow.
  • Travis CI is slower when you compare it with GitHub Actions
  • We do not configure CI very often.

I know, but it needs to be updated at some point.

My PRs to language-* packages all fail because Travis is outdated. See this for an example:
atom/language-python#325

  • Travis continues to remain free for open-source projects, albeit with new limitations.

But Atom is a GitHub product, it is hosted on GitHub. It is much more natural to use something from GitHub itself.

Would like to know if there is an existing precedent, e.g. other atom language repos have migrated to github actions.

An example of a project that currently use it:
https://github.com/atom/github

I use GitHub Actions in all the projects at @atom-ide-community, so we have battle-tested these in our organization.

I have opened PRs for a dozen of the language repos.

Details

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants