Custom colored #168
Merged
Custom colored #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomicals
requested changes
Apr 18, 2024
| if expected_value <= 0 or remaining_value <= 0: | ||
| continue | ||
| if expected_value > txout.value: | ||
| expected_value = txout.value |
There was a problem hiding this comment.
This results in a burn correct?
There was a problem hiding this comment.
If the value to be colored in the payload exceeds the actual Satoshis contained, only the Satoshis actually contained in this UTXO will be colored, and the burn amount will also be calculated correctly.
| for atomical_id, atomical_info in sorted(ft_atomicals.items()): | ||
| remaining_value = atomical_info.total_atomical_value | ||
| for out_idx, txout in enumerate(tx.outputs): | ||
| expected_output_index = str(out_idx) |
There was a problem hiding this comment.
Should we check that isinstance(out_idx, int) is true first?
shadowv0vshadow
force-pushed
the
custom-colored
branch
from
558c810 to
b9e26a1
Compare
atomicals
approved these changes
May 16, 2024
| if expected_value <= 0 or remaining_value <= 0: | ||
| continue | ||
| if expected_value > txout.value: | ||
| expected_value = txout.value |
siriusye
reviewed
May 16, 2024
| # print(hash_to_hex_str(subject_atomical_id1)) | ||
| operation_found_at_inputs = parse_protocols_operations_from_witness_array(tx, tx_hash, True) | ||
| # z means costom color |
|
may I know what will happen if the user input float number in the payload's utxo? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define a "z" op, for custom color outputs.
Payload like this:
We can set any int in every outputs. and custom colored ft.
Be careful, If your payload is flawed, it may lead to unnecessary burned.