Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make LOG_LEVEL env compatible #173

Merged
merged 2 commits into from
Apr 27, 2024
Merged

make LOG_LEVEL env compatible #173

merged 2 commits into from
Apr 27, 2024

Conversation

lucky2077
Copy link
Contributor

@lucky2077 lucky2077 commented Apr 27, 2024 •
edited
Loading

The PR #171 made electrumx_server read LOG_LEVEL from env.

Previously we could use lowercase info because it would automatically convert to uppercase INFO.

atomicals-electrumx/electrumx/server/env.py

Line 73 in dd15e23

self.log_level = self.default('LOG_LEVEL', 'info').upper()
.

When upgrading our RPC endpoint (https://ep.nextdao.xyz/proxy/health) to v1.4.0, it started failed.

AlexV525
AlexV525 approved these changes Apr 27, 2024
View reviewed changes
Copy link
Contributor

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AlexV525 AlexV525 merged commit f37d361 into atomicals:develop Apr 27, 2024
1 check passed
@lucky2077 lucky2077 deleted the fix/LOG_LEVEL_env_breakchange branch April 28, 2024 11:04
@AlexV525 AlexV525 mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexV525 AlexV525 AlexV525 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucky2077 @AlexV525