🐛 Fix payments recognition during advances (#180) #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The verified status of an Atomical relies on the reveal window. The height in the query is the latest advanced block height rather than the processing height, which leads to an incorrect verified status for the container and realm. The issue used to produce incorrect block hashes, probably incorrect Atomicals assets. See height:`tx` records below for more details on the testnet: - 2532818: `b756276cdd06cc188c0266010c9fbf3e416089967a898275ca2909b93081f3ce` - 2569512: `a98015464f0859b5f56011b4c0fb8911a83cac61cd77730744447919c79471a0` Verified with random start heights reindexing on the testnet. ### Before - 2532818: `2973a121b4886ec01ad5676e10e00481edf7662fe5027e1e56704b7f31025050` - 2569512: `45a26b5c0370167df19e0dabb6e57c1e4b631d9812d82832b8c05158447b1942` ### Expected: - 2532818: `918917675000438163934ef4dc882e0883c3fdc2dca3346c178f83e6c7e2ecd2` - 2569512: `dfc1367fc7445a2feb9a39e875cd6f142dabbf27bb63085425bd8a35f738456c`
atomicals
requested review from
AlexV525 and
shadowv0vshadow
and removed request for
shadowv0vshadow
|
#181 should be included along with the release. |
Closing this PR until it is put into develop and then make another PR for release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The verified status of an Atomical relies on the reveal window. The height in the query is the latest advanced block height rather than the processing height, which leads to an incorrect verified status for the container and realm.
The issue used to produce incorrect block hashes, probably incorrect Atomicals assets.
See height:
txrecords below for more details on the testnet:b756276cdd06cc188c0266010c9fbf3e416089967a898275ca2909b93081f3cea98015464f0859b5f56011b4c0fb8911a83cac61cd77730744447919c79471a0Verified with random start heights reindexing on the testnet.
Before
2973a121b4886ec01ad5676e10e00481edf7662fe5027e1e56704b7f3102505045a26b5c0370167df19e0dabb6e57c1e4b631d9812d82832b8c05158447b1942Expected:
918917675000438163934ef4dc882e0883c3fdc2dca3346c178f83e6c7e2ecd2dfc1367fc7445a2feb9a39e875cd6f142dabbf27bb63085425bd8a35f738456c