Apply the activation height to the custom coloring #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wizz-wallet-dev
commented
May 20, 2024
•
wizz-wallet-dev
commented
- Make the custom coloring based on the height, also with the particial coloring.
- Push the activation height to 847000 (~4 weeks after).
wizz-wallet-dev
commented
May 20, 2024
|
|
||
| should_custom_colored_ft_atomicals = is_custom_colored_operation(operations_found_at_inputs) | ||
| should_custom_colored_ft_atomicals = is_custom_colored_operation(operations_found_at_inputs) and is_custom_coloring_activated |
There was a problem hiding this comment.
This applies the activation height limit.
shadowv0vshadow
requested changes
May 20, 2024
electrumx/lib/coins.py
Outdated
| @@ -944,7 +945,7 @@ class BitcoinTestnet(BitcoinTestnetMixin, AtomicalsCoinMixin, Coin): | |||
| ATOMICALS_ACTIVATION_HEIGHT_COMMITZ = 2543936 | |||
| ATOMICALS_ACTIVATION_HEIGHT_DENSITY = 2572729 | |||
| ATOMICALS_ACTIVATION_HEIGHT_DFT_BITWORK_ROLLOVER = 2576412 | |||
| ATOMICALS_ACTIVATION_SPLIT = 2584936 | |||
| ATOMICALS_ACTIVATION_HEIGHT_SPLIT = 2584936 | |||
There was a problem hiding this comment.
should be ATOMICALS_ACTIVATION_HEIGHT_CUSTOM_COLORING
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.