Skip to content

feat: OAuth session#243

Merged
sugyan merged 46 commits intomainfrom
feature/agent-rework
Mar 30, 2025
Merged

feat: OAuth session#243
sugyan merged 46 commits intomainfrom
feature/agent-rework

Conversation

@sugyan
Copy link
Member

@sugyan sugyan commented Nov 8, 2024

No description provided.

@sugyan sugyan force-pushed the feature/agent-rework branch from 2561fcc to 6734492 Compare November 8, 2024 13:55
@ghost
Copy link

ghost commented Nov 24, 2024

What's missing here exactly?

@ghost
Copy link

ghost commented Nov 24, 2024

Caught up with your changes: #242

@sugyan
Copy link
Member Author

sugyan commented Nov 25, 2024

My current thoughts are.

  • Implementation around OAuthSession session management
    • Can we write some tests?
  • Agent rework
    • There should still be methods available in a common interface
    • How to integrate into bsky-sdk?
  • After all, agent rework and OAuth session should be separate features, and pull-request should be able to be separated. Which should be done first?

@ghost
Copy link

ghost commented Nov 28, 2024

Which should be done first?

Seems like the last two PRs dealt with the latter, correct me if I'm wrong and something is missing.

@sugyan
Copy link
Member Author

sugyan commented Nov 28, 2024

@avdb13 I think it would be better to do the agent rework first, but it is a bit tedious and involves some processing specific to atproto, and I think it would be better for me to do it.

As for the OAuthSession part, only the SessionManager trait needs to be added to the api, but other than that, I think your branch is generally implemented. I think it would be possible to merge them if you could split those parts and send them in a separate pull-request.

@ghost
Copy link

ghost commented Dec 18, 2024

I'm gonna wait for this PR to be completed as sebadob/rauthy#644 requires the Agent to be available for us to fetch the email associated with the user's ATProto account, prompting for one if not present.

@ghost
Copy link

ghost commented Dec 24, 2024

it is a bit tedious and involves some processing specific to atproto, and I think it would be better for me to do it.

@sugyan it's been a month since the last commit, I really wanna take on implementing the remaining changes so could you please share instructions? Sorry for my impatience in advance.

@sugyan
Copy link
Member Author

sugyan commented Dec 24, 2024

@avdb13 I am very sorry for the halt in progress.
Since the beginning of December, I have been busy with my personal life and have very little time to concentrate on writing code.... I will try to find time during the year-end and New Year holidays to work on the project, so I would appreciate it if you could wait a little longer.

@ghost
Copy link

ghost commented Dec 24, 2024

@avdb13 I am very sorry for the halt in progress.
Since the beginning of December, I have been busy with my personal life and have very little time to concentrate on writing code.... I will try to find time during the year-end and New Year holidays to work on the project, so I would appreciate it if you could wait a little longer.

I knew something was wrong but I was hesitant to ask about it as this project is driven by voluntary contribution after all. Best of luck and merry christmas!

@sugyan sugyan force-pushed the feature/agent-rework branch from 93fa2f0 to bf05936 Compare February 13, 2025 15:41
@sugyan sugyan mentioned this pull request Feb 14, 2025
@erlend-sh erlend-sh mentioned this pull request Feb 17, 2025
@sugyan sugyan changed the title [WIP] feat: agent rework [WIP] feat: OAuth session Feb 18, 2025
@sugyan sugyan changed the title [WIP] feat: OAuth session feat: OAuth session Mar 30, 2025
@sugyan sugyan marked this pull request as ready for review March 30, 2025 12:52
@sugyan sugyan merged commit 2abe79c into main Mar 30, 2025
15 checks passed
@github-actions github-actions bot mentioned this pull request Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant