chore: Add examples to workspace#283
Merged
sugyan merged 2 commits intoatrium-rs:mainfrom Feb 15, 2025
Merged
Conversation
sugyan
requested changes
Feb 15, 2025
Member
sugyan
left a comment
sugyan
left a comment
There was a problem hiding this comment.
Thank you very much! I agree with this.
It seems that CI is making an error, probably because something I wrote a long time ago was an old formatter. 🙇
I think running cargo fmt-no-gen will fix it.
Contributor
Author
|
@sugyan Done, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on this discussion.
It's hard to keep examples up-to-date with the current state of the repository because they are explicitly targeting the last released version.
However, it's fairly trivial for users to discover the examples for a particular release by looking at the git tags.
Given that, it seems reasonable to just add the examples to the workspace and direct users to use git tags to discover the examples for the previous release.