Updates the DSU peripheral to use the clock::v2 API#925
Open
kyp44 wants to merge 2 commits intoatsamd-rs:feat/clock-v2from
Open
Updates the DSU peripheral to use the clock::v2 API#925kyp44 wants to merge 2 commits intoatsamd-rs:feat/clock-v2from
clock::v2 API#925kyp44 wants to merge 2 commits intoatsamd-rs:feat/clock-v2from
Conversation
This was referenced Jul 14, 2025
Contributor
|
@kyp44 regarding the broken example, I believe this can be worked around as clock::V2 clocks have a .into() method to convert them into their V1 counterparts |
Contributor
Author
|
@rnd-ash The conversion to the v1 types does not help here because |
Contributor
|
Ah right, in this case I personally was calling unsafe to steal mclk .... But you are right, it's probably best to avoid an unsafe block in our examples |
2 tasks
659cc62 to
e9de25c
Compare
* `Dsu::new` now requires ownership of its `AhbClk` and `ApbClk`. * Adds the `Dsu::free` method to free the `pac::Dsu` and bus clocks.
…in the `Dsu` struct per the recommendation in PR atsamd-rs#927.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As part of the
clock::v2effort tracked in Issue #912, this PR updates thedsuto use theclock::v2API by requiring ownership of itsAhbClkandApbClk. Note that this peripheral is only onthumbv7targets.The following Tier 1 BSP examples are now broken and cannot be fixed until the noted peripherals are also migrated and merged (see the notes about this in Issue #912):
feather_m4/nvm_dsu(usb::UsbBus)Checklist
#[allow]certain lints where reasonable, but ideally justify those with a short comment.