-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove atclient_atsign
, atclient_atstr
, refactor a bunch of function signatures
#337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ient_monitor_read, and made atclient_notify_params const in atclient_notify function signature
XavierChanth
approved these changes
Jul 30, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #263
closes #247
closes #267
closes #127
closes #145
closes #153
closes #154
closes #128
closes #129
closes #317
closes #341
closes #335
closes #336
closes #172
closes #226
closes #235
closes #346
closes #342
- What I did
Done as of July 12th:
atclient_atkey_to_string
function signature to takechar **
(originally waschar *buf, const size_t bufsize, size_t *buflen
)atclient_atkey_metadata_to_protocol_str
function signature to takechar **
atclient_put
to reflect changes and added comments to increase readabilityconnection.h/c
atkeysfile.h/c
Done as of July 16th
malloc==NULL
where it was easy to handle itDone as of July 18th
void
to returnint
instead as discussed in at_c: uniformly make all setters returnint
even if it explicitly returns 0 #317atclient_atkey_get_type
and removedatkeytype
fromatclient_atkey
structatkey.name
toatkey.key
Done as of July 20th
Done as of July 22nd
Done as of July 23rd
Done as of July 29th
char **
nowchar **
nowchar **
now- How to verify it
- Description for the changelog