added availability flags and logic for genesis setting #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemanthnakkina-zz
requested changes
Nov 22, 2018
spyglass/data_extractor/formation.py
Outdated
| node_type = 'genesis' | ||
| genesis_set = True | ||
| else: | ||
| node_type = 'genesis' |
There was a problem hiding this comment.
node_type should be genesis in else loop?
There was a problem hiding this comment.
This has been fixed. It should be controller
| hosts_list = [] | ||
| genesis_set = False |
There was a problem hiding this comment.
Is it a design rule to take first node as genesis or hardcoded?
Instead of introducing new flag, why cant the first element is taken out of control_host, handle genesis stuff. And then for loop from [1:]
There was a problem hiding this comment.
Left it for readability sake we can loop fron [1: ] also
purnendu15
requested review from
Kiriti29,
pawansingh126,
gp5ingh and
vgopal
gp5ingh
reviewed
Nov 27, 2018
|
|
||
|
|
||
| 1. Running Spyglass with Remote Data Source | ||
| -s, --site TEXT Specify the site for which manifests to be |
There was a problem hiding this comment.
Should we create plugin as the sub command to spyglass, this will cleanup this help to an extent.
e.g.: spyglass [options] plugin_name [ options]
spyglass --loglevel 10 tugboat ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.