chore: add some optimisations to the AccountId creation methods #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrLSD
approved these changes
Jan 9, 2025
aleksuss
added a commit
that referenced
this pull request
Feb 5, 2025
## Description The PR introduces some optimisations to the creation methods of the `AccounId` struct. Namely, it gets rid of redundant heap allocations. ## Performance / NEAR gas cost considerations There is no changes in the performance. ## Testing The existing tests cover the changes.
Merged
aleksuss
added a commit
that referenced
this pull request
Feb 5, 2025
## [3.8.0] 2025-02-05 ### Changes - Bumped the SputnikVM up to 0.46.1-aurora by [@mrLSD]. ([#966]) - The nightly rust compiler has been replaced with stable by [@aleksuss]. ([#977]) - Added changes regarding bumping the `primitive-types` crate by [@mrLSD]. ([#982]) - The code coverage by clippy has been extended by [@aleksuss]. ([#984]) - The code is changed by the clippy suggestions from the toolchain 1.84.0 by [@mrLSD]. ([#986]) - The precompile `exitToNear` now is compatible with the OMNI bridge by [@aleksuss]. ([#992]) ### Fixes - Added optimisations to the `AccountId` creation methods by [@aleksuss]. ([#985]) - The `README.md` has been actualized by [@aleksuss]. ([#978]) - Modified CI scripts by [@aleksuss]. ([#969], [#973], [#975], [#976], [#981]) - Fixed the vulnerability in the `remove_relayer_key` transaction by [@aleksuss]. ([#972]) [#966]: #966 [#969]: #969 [#972]: #972 [#973]: #973 [#975]: #975 [#976]: #976 [#977]: #977 [#978]: #978 [#981]: #981 [#982]: #982 [#984]: #984 [#985]: #985 [#986]: #986 [#992]: #992 --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: cuibuwei <[email protected]> Co-authored-by: Evgeny Ukhanov <[email protected]> Co-authored-by: omahs <[email protected]> Co-authored-by: Elias Rad <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: cuibuwei <[email protected]> Co-authored-by: NotNotARobot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR introduces some optimisations to the creation methods of the
AccounIdstruct. Namely, it gets rid of redundant heap allocations.Performance / NEAR gas cost considerations
There is no changes in the performance.
Testing
The existing tests cover the changes.