Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: processing deploy_erc20_token and mirror_erc20_token_callback by refiner #189

Merged
merged 7 commits into from
Dec 16, 2024

Conversation

aleksuss
Copy link
Member

No description provided.

@aleksuss
Copy link
Member Author

aleksuss commented Dec 13, 2024

We have the same issue with the mirror_erc20_token_callback, which deploys ERC-20 token as well. But the issue is more complicated because the mirror_erc20_token_callback uses the results of two promises:

  • EOA address of the contract on aurora
  • ERC-20 metadata received from aurora

in its implementation, which we can't get from the processing block.

@birchmd, maybe you have any suggestions on how to deal with the mirror_erc20_token_callback for this case?

@aleksuss aleksuss changed the title fix: processing deploy_erc20_token by refiner fix: processing deploy_erc20_token and mirror_erc20_token_callback by refiner Dec 16, 2024
Copy link
Member

@birchmd birchmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor issue with the hashchain calculation, but otherwise looks good to me!

birchmd
birchmd previously approved these changes Dec 16, 2024
@aleksuss aleksuss merged commit f093a31 into main Dec 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants