UPSTREAM PR #16804: feat(std-rfc/xml xaccess): experimental rewrite of std/xml xaccess#121
Open
loci-dev wants to merge 9 commits into
Open
UPSTREAM PR #16804: feat(std-rfc/xml xaccess): experimental rewrite of std/xml xaccess#121loci-dev wants to merge 9 commits into
std/xml xaccess#121loci-dev wants to merge 9 commits into
Conversation
- adds descendant `//` support using `**` syntax
- uses ...rest param rather than a single list
- params can be cell-path, closure, or a list
- lists are flattened into the rest param, making the api backwards
compatible with the existing implementation
- Rather than reducing data by repeatedly applying closures, it reduces
multiple closures into a single closure, and runs the data through it.
This makes multiple operations into a single pipeline without collecting
between operations
loci-dev
force-pushed
the
main
branch
2 times, most recently
from
d6c3b3e to
aa2e4e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: nushell/nushell#16804
I wrote this a while back and just forgot to make a PR.
AFAIK reducing multiple closures into a single one is (at least in nushell) a novel approach. This is why it's "experimental".
//support using**syntaxwherecommand in a pipelineUsage example:
cc: @weirdan I remember you working with xml, so I would like your take on this.
Release notes summary - What our users need to know
TODO
Tasks after submitting
N/A