Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOB] DEV-3785: ID-6 #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[TOB] DEV-3785: ID-6 #18

wants to merge 1 commit into from

Conversation

preston4896
Copy link
Collaborator

@preston4896 preston4896 commented Feb 10, 2025

This PR fixes the following issues:

  • Asserts the certificate chain length must strictly equal 3
  • The certChainCanBeTrusted() check to perform only at the end of the chain, to prevent the certificate verification from exiting early. (Although this wouldn't happen anyway, given that we are forcing the chain length to be at 3)

@preston4896 preston4896 marked this pull request as ready for review February 13, 2025 06:59
@preston4896 preston4896 changed the title DEV-3785: ID-6 [TOB] DEV-3785: ID-6 Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant