[TOB] DEV-3794: Expiry Check on collateral reads via PCCSRouter #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preston4896
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+310
to
+316
| function _loadDataIfNotExpired(bytes32 key, address dao, uint256 timestamp) private view returns (bool valid) { | ||
| bytes4 COLLATERAL_VALIDITY_SELECTOR = 0x3e960426; | ||
| (bool success, bytes memory ret) = dao.staticcall(abi.encodeWithSelector(COLLATERAL_VALIDITY_SELECTOR, key)); | ||
| require(success, "Failed to determine collateral validity"); | ||
| (uint64 issuedAt, uint64 expiredAt) = abi.decode(ret, (uint64, uint64)); | ||
| valid = timestamp >= issuedAt || timestamp <= expiredAt; | ||
| } |
Check notice
Code scanning / Slither
Block timestamp Low
Comment on lines
+310
to
+316
| function _loadDataIfNotExpired(bytes32 key, address dao, uint256 timestamp) private view returns (bool valid) { | ||
| bytes4 COLLATERAL_VALIDITY_SELECTOR = 0x3e960426; | ||
| (bool success, bytes memory ret) = dao.staticcall(abi.encodeWithSelector(COLLATERAL_VALIDITY_SELECTOR, key)); | ||
| require(success, "Failed to determine collateral validity"); | ||
| (uint64 issuedAt, uint64 expiredAt) = abi.decode(ret, (uint64, uint64)); | ||
| valid = timestamp >= issuedAt || timestamp <= expiredAt; | ||
| } |
Check warning
Code scanning / Slither
Low-level calls Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in this PR:
block.timestampis used.block.timestampor with a specified timestamp by calling*withTimestamp()methods.verifyAndAttestWithZKProofno longer bypasses thetimestampvalue provided in the Output data.timestampis then passed onto*withTimestamp()methods to check the expiration status of corresponding collaterals.This PR partially addresses issue ID-5.