Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV-3731: Resolved ID-1 #18

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

DEV-3731: Resolved ID-1 #18

wants to merge 6 commits into from

Conversation

preston4896
Copy link
Collaborator

This PR introduces the following changes:

  • Check collateral hash to prevent duplicate upserts
  • The issuance date of a new collateral must be strictly greater than the issuance date of existing collaterals

@preston4896
Copy link
Collaborator Author

I am also thinking about renaming all outOfDate terms to notNewer (or something similar)? I think this would be a more accurate description for the rollback prevention check.

Just because a collateral is not "newer", doesn't mean that it is out of date.

@preston4896 preston4896 changed the title Resolved ID-1 DEV-3731: Resolved ID-1 Feb 6, 2025
@preston4896 preston4896 closed this Feb 6, 2025
@preston4896 preston4896 deleted the DEV-3731 branch February 6, 2025 03:02
@preston4896 preston4896 restored the DEV-3731 branch February 6, 2025 03:04
@preston4896 preston4896 reopened this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@preston4896