-
Notifications
You must be signed in to change notification settings - Fork 95
Dynamic HP bounds: Update docs for check_valid_configuration #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thijssnelleman
wants to merge
5
commits into
main
Choose a base branch
from
cehck_valid_configuration_documentation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8bf98b4
Adding new test and docs for issue
thijssnelleman 9550820
test fix
thijssnelleman fc7de13
Update to avoid using deprecated code in test
thijssnelleman a63597f
Fixing test; forcibly broken currently untill PR414 is merged
thijssnelleman a414c6d
Update
thijssnelleman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -616,6 +616,38 @@ def test_check_configuration2(): | |
| configuration.check_valid_configuration() | ||
|
|
||
|
|
||
| def test_check_configuration3(): | ||
| # Test that hyperparameters that follow the conditions and forbiddens will still be rejected if out parameter bounds | ||
| cs = ConfigurationSpace( | ||
| space=[ | ||
| NormalIntegerHyperparameter("a", mu=50, sigma=10, lower=1, upper=10), | ||
| UniformIntegerHyperparameter("b", lower=1, upper=100), | ||
| NormalFloatHyperparameter("c", lower=0, upper=1, mu=0.25, sigma=0.12), | ||
| UniformIntegerHyperparameter("d", lower=0, upper=1), | ||
| BetaFloatHyperparameter("e", lower=0, upper=1, alpha=1, beta=1), | ||
| CategoricalHyperparameter("f", ["Yes", "No", "Maybe"]), | ||
| OrdinalHyperparameter("g", ["Low", "Medium", "High"]), | ||
| ], | ||
| ) | ||
| cs.add( | ||
| NotEqualsCondition(cs["b"], cs["a"], 10), | ||
| ForbiddenEqualsClause(cs["c"], 0), | ||
| ForbiddenEqualsClause(cs["d"], 1), | ||
| ForbiddenEqualsClause(cs["e"], 0), | ||
| ForbiddenEqualsClause(cs["e"], 1), | ||
| ForbiddenAndConjunction( | ||
| ForbiddenEqualsClause(cs["f"], "No"), | ||
| ForbiddenEqualsClause(cs["g"], "Low"), | ||
| ), | ||
| ) | ||
| sample = cs.sample_configuration() | ||
| assert sample.check_valid_configuration() is None # Base sample should pass | ||
|
|
||
| # Parameter A has no conditions; check if the configuration fails if a > 10 | ||
| with pytest.raises(IllegalValueError): | ||
| sample["a"] = 101 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this actually trigger a call to check configuration or does this fail somewhere else?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That is actually a good point, this test fails elsewhere. |
||
|
|
||
|
|
||
| def test_check_forbidden_with_sampled_vector_configuration(): | ||
| cs = ConfigurationSpace() | ||
| metric = CategoricalHyperparameter("metric", ["minkowski", "other"]) | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.