Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a message and a note about improved plotting by increased concurrency #444

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

EmilFattakhov
Copy link
Member

This PR reflects changes introduced in the monorepo PR 2536.
I've also added a short explanation to the cli-tips section, as some users will benefit from changing the default behavior.

Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for subspace-docs-staging ready!

Name Link
🔨 Latest commit b822e1d
🔍 Latest deploy log https://app.netlify.com/sites/subspace-docs-staging/deploys/65d4f531271cb30008a927da
😎 Deploy Preview https://deploy-preview-444--subspace-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EmilFattakhov
Copy link
Member Author

@jim-counter did you say that your CPU load also increased significantly? I can't test the new release myself (and won't be able to test for some time), but I was under the impression that CPU load should decrease, while RAM load increases. Happy to change it if that's not what is happening.

@jim-counter
Copy link
Member

Talking specifically about Space Acres v0.1.3, the default behaviour of the farmer pins all cores on my CPU to 100% and it farms the fastest it ever has.

I think we mean that the feb-19 build leverages the changes from the feb-15 build and is now optimised to use resources to the maximum. This default behaviour can be over-ridden by setting --record-encoding-concurrency 1. CPU load increases because it is more efficient at being able to use every cycle. @nazar-pc is this accurate?

@EmilFattakhov
Copy link
Member Author

Okay that makes sense, "improved CPU usage" in this case means full utilization and increased plotting speeds, rather than more economical resource usage.
Yes, you're right, I just read all the messages from the farmers chat and that what Nazar was hinting towards. Setting concurrency to 1 essentially for the feb-19 release leaves you with feb-15 release plotting speeds.

@nazar-pc
Copy link
Member

nazar-pc commented Feb 20, 2024

This default behaviour can be over-ridden by setting --record-encoding-concurrency 1. CPU load increases because it is more efficient at being able to use every cycle. @nazar-pc is this accurate?

This is accurate, but a small note on "This default behaviour can be over-ridden by setting --record-encoding-concurrency 1", it doesn't quite reach the same performance as feb-05 because the PoSpace is still optimized for throughput, not latency. I am thinking whether it is worth adding some tuning for this option to Space Acres to allow users to choose how much load they want during plotting. Not sure what the selection should be though.

@jim-counter
Copy link
Member

I am thinking whether it is worth adding some tuning for this option to Space Acres to allow users to choose how much load they want during plotting. Not sure what the selection should be though.

I would be grateful for this option. Selecting target CPU load as a percentage would be perfect but I have no idea if that's even possible. Any parameter to dial would work really - it's just how intuitive it would be. Happy to beta test any early builds if you want to experiment.

Copy link
Member

@jim-counter jim-counter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -158,6 +170,12 @@ Example:

### Optimizing DSN Syncing

:::note
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

@EmilFattakhov
Copy link
Member Author

I am thinking whether it is worth adding some tuning for this option to Space Acres to allow users to choose how much load they want during plotting. Not sure what the selection should be though.

+1 on this, would be great to be able to adjust the load, in case you need to keep the PC somewhat usable at the same time.

@EmilFattakhov EmilFattakhov merged commit 18f6674 into main Feb 21, 2024
5 checks passed
@EmilFattakhov EmilFattakhov deleted the add_encoding_concurrency_info branch February 21, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants