virtual_disks_multivms: fix disk discovery #5323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
smitterl
force-pushed
the
fix_multivms
branch
from
9502f76 to
f520cd7
Compare
|
@chunfuwen Please help review, thanks! |
chunfuwen
reviewed
Dec 6, 2023
chunfuwen
reviewed
Dec 6, 2023
chunfuwen
reviewed
Dec 6, 2023
chunfuwen
reviewed
Dec 6, 2023
|
@chunfuwen Thank you for your review, I addressed your feedback. Please, could you review again? |
|
Re-run for patch v2 |
chunfuwen
reviewed
Dec 8, 2023
smitterl
force-pushed
the
fix_multivms
branch
from
f520cd7 to
f7fd768
Compare
|
I've tried to identify the new disk as not mounted and no children that are mounted but then the test at some point mounts it and might not find it anymore. OTOH, using serial doesn't work for LUN type disks "error: unsupported configuration: scsi-block 'lun' devices do not support the serial property" |
smitterl
force-pushed
the
fix_multivms
branch
from
f7fd768 to
2ce6018
Compare
The tests used the disk target as identifier for the disk inside of the VM. However, the target is not guaranteed to show up in the guest as-is, especially given that the /dev/XdY paths are not persistent and can change between boots. Use instead a function that identifies a new disk inside of a VM as the one disk that has no root mount on itself, its partitions or volumes. Finally, the `delete_scsi_disk` doesn't return any value so it was always looping for the full timeout. Wrap it into a function that confirms if both the module and device have been removed. Signed-off-by: Sebastian Mitterle <[email protected]>
smitterl
force-pushed
the
fix_multivms
branch
from
2ce6018 to
ef3a7e9
Compare
|
@chunfuwen I think this is now the final working version. Unfortunately, via serial wouldn't work with LUNs and the algorithm gets a bit more complicated. Please have a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on avocado-framework/avocado-vt#3815
The tests used the disk target as identifier for the
disk inside of the VM. However, the target is not guaranteed
to show up in the guest as-is, especially given that the
/dev/XdY paths are not persistent and can change between boots.
Use instead a function that identifies a new disk inside of a VM
as the one disk that has no root mount on itself, its partitions
or volumes.
Finally, the
delete_scsi_diskdoesn't return any value so itwas always looping for the full timeout. Wrap it into a function
that confirms if both the module and device have been removed.
Signed-off-by: Sebastian Mitterle [email protected]