fix: add icm addr to given genesis #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Closes #2199
For a Custom VM based on Subnet-evm, or for a Subnet-Evm with a user-provided genesis,
there is no automatic allocation of funds into the standard icm deployer address, so
local blockchain deploy fails.
How this works
It fix the logic that checks if a genesis was given (either Custom or Subnet-EVM), and if it was given
as is indeed Subnet-EVM compatible, adds the allocation.
How this was tested
Blockchains conf where created for a given genesis, either by prompt or flag, to custom vm or subnet-evm.
Verifying local deploy works.
How is this documented