enable metrics by default, and set random user id #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipemadero
requested review from
sukantoraymond,
meaghanfitzgerald and
cwend-ava
| return true | ||
| func getMetricsUserID(app *application.Avalanche) string { | ||
| if !app.Conf.ConfigFileExists() || !app.Conf.ConfigValueIsSet(constants.ConfigMetricsUserIDKey) { | ||
| userID := utils.RandomString(20) |
There was a problem hiding this comment.
why are we replacing user id?
Current implementation
hash := sha256.Sum256([]byte(codespaceName)) userID = base64.StdEncoding.EncodeToString(hash[:])
SHA 256 is irreversible
There was a problem hiding this comment.
and it eliminates the need to check for app config files
There was a problem hiding this comment.
checking app config file is not too much of an problem IMO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Improve CLI metrics collection
How this works
How this was tested
How is this documented