Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve swap failure messaging & log them to Sentry #129

Merged
merged 6 commits into from
Feb 19, 2025
Merged

chore: improve swap failure messaging & log them to Sentry #129

merged 6 commits into from
Feb 19, 2025

Conversation

meeh0w
Copy link
Member

@meeh0w meeh0w commented Jan 30, 2025 •
edited
Loading

Description

Changes

  • Improves messaging of possible swap failures (avoid generic Swap Failed toast message)
  • Logs failures to Sentry

Testing

  1. Make swap transactions fail. For example by:
    • blocking Paraswap in dev tools
    • in two-step swaps, approve spend limit, revoke it and then approve the 2nd transaction
    • modifying code
  2. Observe network requests (failures should be reported to Sentry)

Screenshots:

image

Checklist for the author

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

@csabbee csabbee mentioned this pull request Feb 13, 2025
Merged
2 tasks
csabbee
csabbee previously approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@csabbee csabbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor questions about error messages

vvava
vvava previously approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@vvava vvava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@meeh0w meeh0w dismissed stale reviews from vvava and csabbee via 77a2e80 February 19, 2025 07:26
gergelylovas
gergelylovas previously approved these changes Feb 19, 2025
View reviewed changes
csabbee
csabbee approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@csabbee csabbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-

@meeh0w meeh0w merged commit f06d163 into main Feb 19, 2025
6 checks passed
@meeh0w meeh0w deleted the feat/chore-swap-sentry-logging branch February 19, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csabbee csabbee csabbee approved these changes

@gergelylovas gergelylovas gergelylovas approved these changes

@vvava vvava vvava left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@meeh0w @csabbee @gergelylovas @vvava