Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle newlines in address input #13

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Aug 2, 2024

Description

Described in: https://ava-labs.atlassian.net/browse/CP-8970

Changes

Simply trims input within the <ContactInput /> TextField. This brings it in parity with how the address input on core.app behaves.

Testing

  1. Following the steps in the issue, attempt to prepend a newline to the input, then paste an address
  2. Confirm the newline is trimmed and no Unknown or other errors occur
  3. See the send form on core.app for comparison

Checklist for the author

Tick each of them when done or if not applicable.

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

@ryanml ryanml merged commit b865c93 into main Aug 2, 2024
3 of 4 checks passed
@ryanml ryanml deleted the fix/CP-8970_fix_address_input branch August 2, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants