Skip to content

Conversation

@rkefi
Copy link

@rkefi rkefi commented Aug 12, 2024

Description

Add support for PRs from forks

Error :

Determining the checkout info /usr/bin/git branch --list --remote origin/feat/locales-fr /usr/bin/git tag --list feat/locales-fr Error: A branch or tag with the name 'feat/locales-fr' could not be found

Update the checkout section to handle the pull_request event

Changes

Testing

Auto smoke tests E2E had only 1 failure due to a page not fully loaded

Screenshots:

Screenshot 2024-08-12 at 12 19 54 PM

Checklist for the author

Tick each of them when done or if not applicable.

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

@rkefi rkefi added the DO NOT MERGE This PR is not meant to be merged in its current state label Aug 12, 2024
@rkefi rkefi requested review from blockqa and gergelylovas August 12, 2024 16:08
Copy link
Contributor

@blockqa blockqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE This PR is not meant to be merged in its current state

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants