Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: CP-8911 update packages #28

Closed
wants to merge 1 commit into from

Conversation

vvava
Copy link
Contributor

@vvava vvava commented Aug 19, 2024

Description

We had an issue with the tokens' price when a bridging tx was in progress. The price sometimes was 0.

Changes

The bridge config did not be loaded therefor it threw an error which was an empty object. Now we are waiting for the service to get the config before we want to get the data from there.
https://github.com/ava-labs/avalanche-sdks/pull/664

Testing

Try a bridging tx and check the price of the token.

Screenshots:

Checklist for the author

Tick each of them when done or if not applicable.

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

@meeh0w
Copy link
Member

meeh0w commented Aug 22, 2024

@vvava I tested and it works:
image

I think we can close this PR like you said yesterday - there is another one in queue which updates to a higher version :)

@vvava
Copy link
Contributor Author

vvava commented Aug 22, 2024

@vvava I tested and it works: image

I think we can close this PR like you said yesterday - there is another one in queue which updates to a higher version :)

Looks great, thanks a lot!

@vvava vvava closed this Aug 22, 2024
@vvava
Copy link
Contributor Author

vvava commented Aug 22, 2024

duplicated by #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants