Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update sdks #29

Merged
merged 1 commit into from
Aug 22, 2024
Merged

chore: update sdks #29

merged 1 commit into from
Aug 22, 2024

Conversation

meeh0w
Copy link
Member

@meeh0w meeh0w commented Aug 21, 2024

Description

Updates SDKs, the new version changes BTC fee estimation:

  • Normal preset will estimate for tx inclusion within 6 blocks instead of 7
  • fee rate is rounded up instead of to the closest integer (e.g. 3.4 -> 4.0 instead of 3.4 -> 3.0)

Checklist for the author

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

@bferenc
Copy link
Contributor

bferenc commented Aug 21, 2024

Gave it a test and I was constantly getting one of these 2 results 🤔
image
Screenshot 2024-08-21 at 15 22 17

@meeh0w
Copy link
Member Author

meeh0w commented Aug 21, 2024

@bferenc The first looks like fees from EVM leaking through (a race condition probably, I've suspected it here a few months back, but was not able to reproduce).

The 2nd are the proper BTC testnet fees (yup...I know...pretty expensive 😆).

bferenc
bferenc previously approved these changes Aug 21, 2024
@meeh0w
Copy link
Member Author

meeh0w commented Aug 21, 2024

@bferenc I just got this idea and managed to reproduce the 1st one by triggering a BTC send, opening a 2nd extension window and changing the network to C-Chain in it.

I'll file a bug ticket!

@bferenc
Copy link
Contributor

bferenc commented Aug 21, 2024

@bferenc I just got this idea and managed to reproduce the 1st one by triggering a BTC send, opening a 2nd extension window and changing the network to C-Chain in it.

I'll file a bug ticket!

Awesome, thank you!

@meeh0w
Copy link
Member Author

meeh0w commented Aug 21, 2024

Ticket: https://ava-labs.atlassian.net/browse/CP-9098

@meeh0w
Copy link
Member Author

meeh0w commented Aug 21, 2024

@bferenc Can you re-approve? I had to rebase :)

@bferenc bferenc self-requested a review August 21, 2024 14:05
@meeh0w meeh0w merged commit a92b9b5 into main Aug 22, 2024
5 checks passed
@meeh0w meeh0w deleted the chore/update-sdk-deps branch August 22, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants