Skip to content

fix: unnecessary fee buffers#948

Merged
meeh0w merged 1 commit into
mainfrom
fix/swap-inconcistency
Jun 10, 2026
Merged

fix: unnecessary fee buffers#948
meeh0w merged 1 commit into
mainfrom
fix/swap-inconcistency

Conversation

@meeh0w

@meeh0w meeh0w commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

Jira ticket: no ticket
Figma: n/a

Notes

  • Removes no-longer-necessary buffer being applied to Solana -> EVM cross-chain swaps
  • Removes no-longer-necessary buffer being applied to the network fee (+10% for Bitcoin remains)

Testing

  • Verify the reported fees for SOL -> ETH match Core Web

Media

n/a

@meeh0w meeh0w requested a review from a team as a code owner June 8, 2026 10:33
Copilot AI review requested due to automatic review settings June 8, 2026 10:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes additional fee “buffers” previously applied in the Fusion (swap) flow, relying instead on the Fusion SDK’s native fee margin (feeUnitsMarginBps) while keeping the explicit 10% Bitcoin buffer.

Changes:

  • Removed the Solana → EVM native fee multiplier logic (and the associated helper/constant).
  • Removed the extra non-Bitcoin network-fee buffer in required token amount calculations (Bitcoin +10% remains).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
apps/next/src/pages/Fusion/lib/isSolanaToEvm.ts Removed Solana→EVM quote detection helper (no longer needed after multiplier removal).
apps/next/src/pages/Fusion/fusion-config.ts Removed the Solana→EVM native fee multiplier constant.
apps/next/src/pages/Fusion/contexts/hooks/useRequiredTokenAmounts.ts Set non-Bitcoin network-fee buffer to 0 (keeps Bitcoin at 10%).
apps/next/src/pages/Fusion/contexts/hooks/useNativeFeeEstimate.ts Removed Solana→EVM-specific fee buffering; now returns SDK totalFee directly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@meeh0w meeh0w merged commit 1fdfc3a into main Jun 10, 2026
11 checks passed
@meeh0w meeh0w deleted the fix/swap-inconcistency branch June 10, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants