fix: unnecessary fee buffers#948
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes additional fee “buffers” previously applied in the Fusion (swap) flow, relying instead on the Fusion SDK’s native fee margin (feeUnitsMarginBps) while keeping the explicit 10% Bitcoin buffer.
Changes:
- Removed the Solana → EVM native fee multiplier logic (and the associated helper/constant).
- Removed the extra non-Bitcoin network-fee buffer in required token amount calculations (Bitcoin +10% remains).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/next/src/pages/Fusion/lib/isSolanaToEvm.ts | Removed Solana→EVM quote detection helper (no longer needed after multiplier removal). |
| apps/next/src/pages/Fusion/fusion-config.ts | Removed the Solana→EVM native fee multiplier constant. |
| apps/next/src/pages/Fusion/contexts/hooks/useRequiredTokenAmounts.ts | Set non-Bitcoin network-fee buffer to 0 (keeps Bitcoin at 10%). |
| apps/next/src/pages/Fusion/contexts/hooks/useNativeFeeEstimate.ts | Removed Solana→EVM-specific fee buffering; now returns SDK totalFee directly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
csabbee
approved these changes
Jun 10, 2026
blockqa
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Jira ticket: no ticket
Figma: n/a
Notes
Testing
Media
n/a