Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-9946 & CP-9947: Add Action Buttons to Watchlist #2336

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

atn4z7
Copy link
Collaborator

@atn4z7 atn4z7 commented Feb 28, 2025

Description

Ticket: CP-9946
Ticket: CP-9947

  • add buy, stake, swap buttons to Watchlist. please refer to the tickets for the logic.
  • buy is now enabled for all networks and not just Avalanche C-Chain
  • add halliday as another buy option in Buy screen

figma design

Screenshots/Videos

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-02-28.at.15.18.11.mp4

Testing

Please test the following features in the watchlist tab:

  • trending tokens, favorite tokens and all tokens are loaded normally.
  • token searching works
    • it will first search all the local lists
    • if not found, then it will try searching with coingecko api
  • token sorting works
  • buy, stake, swap buttons work
  • token details screen is loaded normally
  • token favorite/unfavorite works

Checklist

Please check all that apply (if applicable)

  • I have performed a self-review of my code
  • I have verified the code works
  • I have added/updated necessary unit tests
  • I have updated the documentation

@@ -44,6 +49,6 @@ export function formatNumber(num: number | string): string {
return roundToFirstNonZeroDecimal(rawValue)
} else {
// handle normal numbers
return rawValue.toFixed(2)
return normalNumberFormatter.format(rawValue)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onghwan this adds back the comma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant