align types/block.go with subnet-evm #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
changed the title
ceyonur
approved these changes
Jan 24, 2024
ceyonur
approved these changes
Jan 24, 2024
marun
reviewed
Jan 26, 2024
marun
approved these changes
Jan 26, 2024
darioush
pushed a commit
that referenced
this pull request
Apr 25, 2024
oxbee
pushed a commit
to taurusgroup/coreth
that referenced
this pull request
Nov 6, 2024
* align types/block.go with addative upstream * align with subnet-evm for now * add copyright header * rename to WithExtData
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR moves extra methods defined on the block type (compared to subnet-evm) to its own file, and also separates out methods that create the block with ExtData so the no-ExtData methods are textually compatible with upstream & subnet-evm
How this works
Refactoring
How this was tested
CI