chore(lint): cleanup config and enable default linters for our code #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
force-pushed
the
qdm12/linter-new-only
branch
2 times, most recently
from
f9798f5 to
3eddab0
Compare
qdm12
changed the title
qdm12
force-pushed
the
qdm12/linter-new-only
branch
from
3eddab0 to
bff54b5
Compare
qdm12
force-pushed
the
qdm12/linter-new-only
branch
from
bff54b5 to
8b2feae
Compare
qdm12
force-pushed
the
qdm12/linter-new-only
branch
from
44b1570 to
31da1de
Compare
qdm12
commented
Feb 13, 2025
| _, err := rand.Read(blocksBytes[i]) | ||
| assert.NoError(t, err) | ||
| } | ||
| blocksBytes := [][]byte{ |
There was a problem hiding this comment.
All these are the same values that were previously pseudo random generated, but I removed math/rand to make gosec happy; alternatively I can (did 1 in the last commit):
- Use smaller deterministic values set without a generator and change the tests expectations since the generated values would be different. My preferred because randomness has no place where it's actually not needed. This is done in the last commit.
//nolint:goseca bunch of places (I don't recommend)- Disable gosec about weak generator for test files (eh it's ok, but not totally recommended either)
The same goes for a few other tests changed the same way as this one.
| go vmSetup.serverVM.AppRequest(ctx, nodeID, requestID, time.Now().Add(1*time.Second), request) | ||
| go func() { | ||
| err := vmSetup.serverVM.AppRequest(ctx, nodeID, requestID, time.Now().Add(1*time.Second), request) | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
note technically this should only be called in the test goroutine, but this would involve significant changes that are out of scope in this PR, so leaving this as is. It would still detect the failure, but may panic if the test goroutine finished and this goroutine fails after that.
Comment on lines
+372
to
+375
| err := a.trieDB.Dereference(a.lastAcceptedRoot) | ||
| if err != nil { | ||
| return false, fmt.Errorf("dereferencing last accepted root: %w", err) | ||
| } |
There was a problem hiding this comment.
note: i forgot to check the error here, showing the point of errcheck 😄 Risky business otherwise!
qdm12
force-pushed
the
qdm12/linter-new-only
branch
3 times, most recently
from
1b632eb to
17cf418
Compare
qdm12
force-pushed
the
qdm12/linter-new-only
branch
from
17cf418 to
48a4806
Compare
Co-authored-by: Martin HS <[email protected]> Co-authored-by: Marius van der Wijden <[email protected]> Co-authored-by: Quentin McGaw <[email protected]>
- enable errcheck, gosimple, govet, staticcheck - only scans plugin directory and _ext.go files - fix lint errors
qdm12
force-pushed
the
qdm12/linter-new-only
branch
from
48a4806 to
c80529b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Enable default linters (errcheck, staticcheck, gosimple and staticcheck were missing) +
errorlintfor our code only:./plugin/*.gofiles*libevm*.gofiles_ext.gofilesMore linters can be added subsequently, but this PR fixes already quite a few errors already coming from enabling the default linters and errorlint in our code
How this works
How this was tested
Need to be documented?
No
Need to update RELEASES.md?
No