chore(core/rawdb): InspectDatabase uses libevm (8)
#791
+53
−181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
force-pushed
the
qdm12/core/rawdb/inspect-database
branch
from
6c4bbc2 to
1d24024
Compare
6 tasks
qdm12
force-pushed
the
qdm12/core/rawdb/inspect-database
branch
from
2fc3ab9 to
eafaffd
Compare
qdm12
force-pushed
the
qdm12/libevm-phase-2.5
branch
2 times, most recently
from
d311ae1 to
fe9ce00
Compare
qdm12
force-pushed
the
qdm12/core/rawdb/inspect-database
branch
from
eafaffd to
e6470d4
Compare
qdm12
changed the title
InspectDatabase uses libevmInspectDatabase uses libevm (2)
qdm12
changed the title
InspectDatabase uses libevm (2)InspectDatabase uses libevm (6)
qdm12
changed the base branch from
qdm12/libevm-phase-2.5
to
qdm12/core/types/body-libevm
qdm12
changed the title
InspectDatabase uses libevm (6)InspectDatabase uses libevm (7)
qdm12
changed the base branch from
qdm12/core/types/body-libevm
to
qdm12/core/rawdb/inspect-database-test
qdm12
force-pushed
the
qdm12/core/rawdb/inspect-database-test
branch
from
59d9f05 to
6a5b763
Compare
qdm12
force-pushed
the
qdm12/core/rawdb/inspect-database
branch
from
e6470d4 to
710c622
Compare
qdm12
force-pushed
the
qdm12/core/rawdb/inspect-database-test
branch
from
6a5b763 to
1aa5bea
Compare
qdm12
force-pushed
the
qdm12/core/rawdb/inspect-database
branch
from
710c622 to
0b398d6
Compare
qdm12
changed the title
InspectDatabase uses libevm (7)InspectDatabase uses libevm (8)
qdm12
force-pushed
the
qdm12/core/rawdb/inspect-database-test
branch
from
1aa5bea to
e2333a2
Compare
Base automatically changed from
qdm12/core/rawdb/inspect-database-test
to
libevm
February 28, 2025 18:44
- Using libevm `InspectDatabase` - Define options passed to libevm `InspectDatabase`
qdm12
force-pushed
the
qdm12/core/rawdb/inspect-database
branch
from
0b398d6 to
67a9d12
Compare
darioush
previously approved these changes
Feb 28, 2025
ceyonur
reviewed
Feb 28, 2025
qdm12
force-pushed
the
qdm12/core/rawdb/inspect-database
branch
from
7fe0168 to
26ccd5d
Compare
darioush
approved these changes
Feb 28, 2025
ARR4N
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
You can really simplify this by converting it to a table-driven approach as you're applying identical logic to 4 sets of parameters. Feel free to use that commit or merge as is if you prefer.
Tip
If you want to use it you can easily fast-forward with git merge --ff-only origin/arr4n/core/rawdb/inspect-database from your branch.
ceyonur
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InspectDatabaseInspectDatabase