Skip to content

Commit

Permalink
fix(android, new arch): Do not execute commands twice (react-native-w…
Browse files Browse the repository at this point in the history
…ebview#3552)

No need to manually call the methods, the generated delegate already does that for us.
  • Loading branch information
Titozzz authored Sep 9, 2024
1 parent 2a1cddc commit 9953ca0
Showing 1 changed file with 0 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,6 @@ public void setUserAgent(RNCWebViewWrapper view, @Nullable String value) {
mRNCWebViewManagerImpl.setUserAgent(view, value);
}

// These will never be called because we use the shared impl for now
@Override
public void goBack(RNCWebViewWrapper view) {
view.getWebView().goBack();
Expand Down Expand Up @@ -499,7 +498,6 @@ public void clearCache(RNCWebViewWrapper view, boolean includeDiskFiles) {
public void clearHistory(RNCWebViewWrapper view) {
view.getWebView().clearHistory();
}
// !These will never be called

@Override
protected void addEventEmitters(@NonNull ThemedReactContext reactContext, RNCWebViewWrapper view) {
Expand Down Expand Up @@ -538,7 +536,6 @@ Map<String, Integer> getCommandsMap() {

@Override
public void receiveCommand(@NonNull RNCWebViewWrapper reactWebView, String commandId, @Nullable ReadableArray args) {
mRNCWebViewManagerImpl.receiveCommand(reactWebView, commandId, args);
super.receiveCommand(reactWebView, commandId, args);
}

Expand Down

0 comments on commit 9953ca0

Please sign in to comment.