Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move AllowUnfinalizedQueries out of vm.Config #1052

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

darioush
Copy link
Collaborator

@darioush darioush commented Jan 22, 2024

Why this should be merged

Align with coreth

How this works

Applies ava-labs/coreth#443 from coreth

How this was tested

CI

How is this documented

N/A

@darioush darioush changed the title remove ethdb refactor: move AllowUnfinalizedQueries out of vm.Config Jan 22, 2024
@darioush darioush marked this pull request as ready for review January 22, 2024 21:56
ceyonur
ceyonur previously approved these changes Jan 23, 2024
JacobEverly
JacobEverly previously approved these changes Jan 23, 2024
Base automatically changed from remove-ethdb to master January 23, 2024 20:13
@ceyonur ceyonur dismissed stale reviews from JacobEverly and themself January 23, 2024 20:13

The base branch was changed.

@darioush darioush enabled auto-merge (squash) January 23, 2024 20:21
@ceyonur ceyonur disabled auto-merge January 23, 2024 20:32
@ceyonur ceyonur merged commit 955377b into master Jan 23, 2024
10 checks passed
@ceyonur ceyonur deleted the align-unfinalized-queries branch January 23, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants