Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): use go.mod version and remove unused lint.sh #1456

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+9 −31
Open

chore(ci): use go.mod version and remove unused lint.sh #1456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03729aa
chore(scripts): remove lint.sh (#834)
ceyonur Feb 25, 2025
e8c0329
chore(ci): use go.mod Go version for actions/setup-go (#836)
ceyonur Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/bench.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ jobs:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v4
- uses: actions/setup-go@v5
with:
go-version: "~1.23.6"
go-version-file: "go.mod"
- run: go mod download
shell: bash
- run: ./scripts/build_bench_precompiles.sh
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: "~1.23.6"
go-version-file: "go.mod"
- name: Set up arm64 cross compiler
run: |
sudo apt-get -y update
Expand Down
15 changes: 6 additions & 9 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ on:
- "*"
pull_request:

env:
min_go_version: "~1.23.6"

jobs:
lint_test:
name: Lint
Expand All @@ -21,7 +18,7 @@ jobs:
shell: bash
- uses: actions/setup-go@v5
with:
go-version: ${{ env.min_go_version }}
go-version-file: "go.mod"
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
Expand Down Expand Up @@ -51,7 +48,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ${{ env.min_go_version }}
go-version-file: "go.mod"
- name: Set timeout on Windows # Windows UT run slower and need a longer timeout
shell: bash
if: matrix.os == 'windows-latest'
Expand Down Expand Up @@ -85,7 +82,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: ${{ env.min_go_version }}
go-version-file: "go.mod"
- name: Use Node.js
uses: actions/setup-node@v4
with:
Expand Down Expand Up @@ -126,7 +123,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: ${{ env.min_go_version }}
go-version-file: "go.mod"
- name: Use Node.js
uses: actions/setup-node@v4
with:
Expand Down Expand Up @@ -170,7 +167,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: ${{ env.min_go_version }}
go-version-file: "go.mod"
- name: Install AvalancheGo Release
shell: bash
run: BASEDIR=/tmp/e2e-test AVALANCHEGO_BUILD_PATH=/tmp/e2e-test/avalanchego ./scripts/install_avalanchego_release.sh
Expand Down Expand Up @@ -205,7 +202,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ${{ env.min_go_version }}
go-version-file: "go.mod"
- name: Install AvalancheGo Release
shell: bash
run: BASEDIR=/tmp/e2e-test AVALANCHEGO_BUILD_PATH=/tmp/e2e-test/avalanchego ./scripts/install_avalanchego_release.sh
Expand Down
19 changes: 0 additions & 19 deletions scripts/lint.sh
View file
Open in desktop

This file was deleted.

Loading